Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of plugins #6750

Merged
merged 12 commits into from
Feb 27, 2023
Merged

Fix loading of plugins #6750

merged 12 commits into from
Feb 27, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 27, 2023

Fixes #6399

  • Move the list of plugins included in the notebook application to app/package.json
  • Pass the list of plugins available on all the pages (tree, notebooks, edit) so the app is aware of other plugins loaded on other pages
  • Add logic to explicitly load the notebook built-in plugins with settingRegistry.load(plugin) so they are properly displayed in the settings editor:

Before

image

After

The settings editor now includes the "Debugger" entry while the debugger extension is only loaded on the notebook page.

image

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/plugins

@jtpio jtpio added this to the 7.0 milestone Feb 27, 2023
@jtpio jtpio marked this pull request as ready for review February 27, 2023 09:03
@jtpio jtpio merged commit 2e4886f into jupyter:main Feb 27, 2023
@jtpio jtpio deleted the plugins branch February 27, 2023 09:32
jitseniesen added a commit to jitseniesen/spyder-notebook that referenced this pull request Mar 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the loading of extensions in index.js
1 participant