Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Notebook ecosystem docs improvements #6877

Merged
merged 20 commits into from
May 31, 2023

Conversation

ericsnekbytes
Copy link
Collaborator

This is part of a Jupyter-wide effort to better explain the Jupyter ecosystem to the community, by improving documentation for the Jupyter Project and its individual subprojects, and interlinking them.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch ericsnekbytes/notebook/docs_notebook_ecosystem

@ericsnekbytes ericsnekbytes changed the title (DRAFT) Add Project Jupyter info, extra context and detail to home page/index. (DRAFT) Jupyter Notebook ecosystem docs improvements May 16, 2023
@ericsnekbytes ericsnekbytes changed the title (DRAFT) Jupyter Notebook ecosystem docs improvements Jupyter Notebook ecosystem docs improvements May 22, 2023
@ericsnekbytes ericsnekbytes marked this pull request as ready for review May 22, 2023 14:33
Copy link
Contributor

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @ericsnekbytes. Please find some comments and suggestions below.

docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Show resolved Hide resolved
docs/source/index.md Show resolved Hide resolved
docs/source/notebook.md Show resolved Hide resolved
@ericsnekbytes
Copy link
Collaborator Author

@krassowski Can you approve/merge this?

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echarles
Copy link
Member

Build / tests_check (pull_request) Failing after 2s is tagged as Required but is failing. Is it ok to merge?

@ericsnekbytes
Copy link
Collaborator Author

@krassowski @jtpio Does anyone know why check_links is failing because ModuleNotFoundError: No module named 'typing_extensions'? This seems like a flaky test...

@jtpio
Copy link
Member

jtpio commented May 30, 2023

I restarted the check to make sure.

@jtpio jtpio added this to the 7.0 milestone May 30, 2023
@ericsnekbytes
Copy link
Collaborator Author

I restarted the check to make sure.

Thank you!

@jtpio
Copy link
Member

jtpio commented May 30, 2023

Another way to double check would be to open a draft PR with a dummy change and see of the check also fails there.

@echarles
Copy link
Member

I restarted the check to make sure.

I had also restarted and it failed with the same error. I don't think it is related to this PR, but the job is marked as Required, so worth to fix it.

@jtpio
Copy link
Member

jtpio commented May 30, 2023

Yeah if anyone can look into fixing it that would be great, thanks.

@ericsnekbytes
Copy link
Collaborator Author

@blink1073 Any insight here? I'm just trying to merge simple this simple markdown update PR, and the CI is preventing that :(

@krassowski
Copy link
Member

Well that's clearly an upstream issue due to a faulty release of cattrs four hours ago, there is an issue open already: python-attrs/cattrs#369

@henryiii
Copy link

A quick fix would be either restricting 23.1.0 exactly or adding the transitive dependency, like in scikit-build/scikit-build-core@4b6dcfb.

@henryiii
Copy link

Fixed version released and old one was yanked. So should be fine now.

@jtpio
Copy link
Member

jtpio commented May 31, 2023

Thanks @henryiii!

@jtpio
Copy link
Member

jtpio commented May 31, 2023

@ericsnekbytes so re-running the check gives the following error which looks related:

image

Jupyter Notebook offers a lightweight, simplified experience compared to JupyterLab.

Read more about how to use **Jupyter Notebook** on this site, in the [User
Documentation](notebook).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing an updated link now.

@ericsnekbytes
Copy link
Collaborator Author

@jtpio @krassowski @henryiii Checks have passed now, can someone merge this?

@jtpio jtpio merged commit 11cb93f into jupyter:main May 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants