-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter Notebook ecosystem docs improvements #6877
Conversation
…tebook into docs_notebook_ecosystem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @ericsnekbytes. Please find some comments and suggestions below.
@krassowski Can you approve/merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build / tests_check (pull_request) Failing after 2s is tagged as Required but is failing. Is it ok to merge? |
@krassowski @jtpio Does anyone know why check_links is failing because |
I restarted the check to make sure. |
Thank you! |
Another way to double check would be to open a draft PR with a dummy change and see of the check also fails there. |
I had also restarted and it failed with the same error. I don't think it is related to this PR, but the job is marked as |
Yeah if anyone can look into fixing it that would be great, thanks. |
@blink1073 Any insight here? I'm just trying to merge simple this simple markdown update PR, and the CI is preventing that :( |
Well that's clearly an upstream issue due to a faulty release of cattrs four hours ago, there is an issue open already: python-attrs/cattrs#369 |
A quick fix would be either restricting 23.1.0 exactly or adding the transitive dependency, like in scikit-build/scikit-build-core@4b6dcfb. |
Fixed version released and old one was yanked. So should be fine now. |
Thanks @henryiii! |
@ericsnekbytes so re-running the check gives the following error which looks related: |
docs/source/index.md
Outdated
Jupyter Notebook offers a lightweight, simplified experience compared to JupyterLab. | ||
|
||
Read more about how to use **Jupyter Notebook** on this site, in the [User | ||
Documentation](notebook). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing an updated link now.
@jtpio @krassowski @henryiii Checks have passed now, can someone merge this? |
This is part of a Jupyter-wide effort to better explain the Jupyter ecosystem to the community, by improving documentation for the Jupyter Project and its individual subprojects, and interlinking them.