Enhance handling of input from other clients #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmvanvliet
changed the title
ccordoba12
changed the title
What were the previous failures that this PR fixes? |
ccordoba12
reviewed
May 3, 2017
| @@ -494,6 +494,13 @@ def sizeHint(self): | |||
| Outputs are not displayed until enter is pressed. | |||
| """ | |||
| ) | |||
|
|
|||
| other_output_prefix = Unicode('[remote] ', config=True, | |||
There was a problem hiding this comment.
Why is this value set to [remote]?
There was a problem hiding this comment.
That's the default used in the jupyter console client. I copied the feature from there.
|
I've updated the description of this PR to be more informative. |
wmvanvliet
force-pushed
the
other_input
branch
from
8f03529
to
7454da9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
c.ConsoleWidget.include_other_output = Trueswitch will make QtConsole display input given to the kernel that was initiated by other clients. For example, a text editor can connect to the kernel and allow users to select pieces of code and execute them (like the F9 button in Spyder and MATLAB).This PR fixes some bugs and adds some enhancements when displaying "other_input" and "other_output".
[remote] In [n]:prompt for other_input and an[remote] Out[n]:prompt for other_output (like jupyter-console does)other_output_prefixto change the[remote]prefix above to something else (like jupyter-console has)