Add exec_prefix option #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds the option exec_prefix which can be used for overriding
the sudo command to use when manipulating jobs.
- This defaults to "sudo -E -u {username}" and is appended to every
command before it is run.
- The condor_q command did not have this, but likely can be used here.
- Closes: jupyterhub#39
This was referenced Apr 28, 2018
willingc
reviewed
May 23, 2018
There was a problem hiding this comment.
@rkdarst The Python code looks good to me. I'm not familiar enough with the batch commands and will defer to @mbmilligan on those. Thanks.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sudo command to use when manipulating jobs.
command before it is run.
Missing and very important: tests to ensure that exec_prefix is actually used. But please pull #72 first since that will make things easier to test.