Skip to content

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented May 21, 2018

I'm not necessarily saying that this is a good idea. From #78:

I tend to think that HPC is rather conservative and slow to upgrade, so my inclination is to support backwards compatibility a lot. But, JupyterHub is changing so fast it probably doesn't make sense to use anything older than 0.8.1 anyway.

If it was up to me, I would say "yes" for the main reason that I'm not going to be able to support older versions very well since I have only recently started here. If we don't do this, can someone help with older versions?

Thoughts?

@willingc
Copy link
Contributor

Good points @rkdarst. I left comments in #78. Perhaps adding versions back in the test matrix and see where that breaks would be a reasonable experiment. ☀️

@willingc
Copy link
Contributor

And thank you @rkdarst for all of the PRs. I will review the code on all of them today (sorry for the delay). After I do that, perhaps @minrk and @mbmilligan can take a look from an HPC perspective.

@rkdarst rkdarst force-pushed the min_jupyterhub_0.8.1 branch from cf9a873 to 8c7dd10 Compare May 21, 2018 19:34
@rkdarst
Copy link
Contributor Author

rkdarst commented May 21, 2018

Now updated for {0.8, 0.9, master} × {3.5, 3.6} + (0.5, 3.3) + (0.7, 3.4). I also removed master from allowed_failures: at least for the way I am developing, requiring it to succeed on master is acceptable.

If the progress method can't me made to work on 3.3-3.4 and 3.5-3.6 at the same time, we may have to remove the python<=3.4.

Thoughts?

This is still to-be discussed and not ready to go.

@rkdarst rkdarst force-pushed the min_jupyterhub_0.8.1 branch 2 times, most recently from 628e6ba to aff7573 Compare May 21, 2018 20:03
@mbmilligan
Copy link
Member

mbmilligan commented May 21, 2018

Ok, this latest commit looks like it matches my recommendations from #78, so I'm happy with that.

Looks like Travis doesn't actually support Python 3.7 yet though?

EDIT: Oh, you noticed that too. Anyway, once Travis is happy I'll merge this.

@willingc
Copy link
Contributor

Yeah, 3.7 is still in RC so I'm not surprised. Perhaps add nightly but allow failures on it.

@rkdarst rkdarst force-pushed the min_jupyterhub_0.8.1 branch from aff7573 to a481795 Compare May 21, 2018 20:20
- Mirrors the latest requirements of JupyterHub.
- Discussion in jupyterhub#78.
@rkdarst rkdarst force-pushed the min_jupyterhub_0.8.1 branch from a481795 to 8d28de2 Compare May 21, 2018 20:37
@mbmilligan mbmilligan merged commit 872e568 into jupyterhub:master May 22, 2018
@rkdarst rkdarst deleted the min_jupyterhub_0.8.1 branch June 18, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants