Clarify confusing AssertionError when pending batch process disappears #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkdarst
force-pushed
the
pending_disappears_error_msg
branch
from
433cb6c to
685ae41
Compare
|
Updated so that tests pass, also change another submission AssertionError to RuntimeError with good message. Also several other asserts were given useful info. I could give more useful info to the raise in run_command, but that got moved in my other PR so I'm not doing it just yet... |
- Clarify the batch submit process error messages. Previously, this was an AssertionError, whose text was presented to the user in a very confusing fashion. - Add debugging info to several asserts which assert for misconfiguration.
rkdarst
force-pushed
the
pending_disappears_error_msg
branch
from
685ae41 to
da5a2f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssertionError, whose text was presented to the user in a very
confusing fashion.
Related: jupyterhub/jupyterhub#1915