SlurmSpawner: make "srun" optional #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To properly run in slurm, one is supposed to use "srun" for each job step (though this isn't required). dff4482 added the srun, but this has some side-effects, mainly (for me at least) that environment is *actually* handled the way it should be. But this broke some functionality that depended on environment. Since this caused problems, and may cause problems for others, "srun" should be made optional. This does that. - The root problem is that the batch script reads .bashrc / .bash_profile, but when the notebook server is run using 'srun', it clears these environment variables and uses only the keepvars setting. (Of course, this itself is a security risk and the initial purpose of limiting the environment). - To disable srun, set SlurmSpawner.req_srun=''. - If, upon upgrading, your environment goes crazy and you aren't seeing environment variables you expected, try setting this to ''.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step (though this isn't required). dff4482 added the srun, but this
has some side-effects, mainly (for me at least) that environment is
actually handled the way it should be. But this broke some
functionality that depended on environment. Since this caused
problems, and may cause problems for others, "srun" should be made
optional. This does that.
.bash_profile, but when the notebook server is run using 'srun', it
clears these environment variables and uses only the keepvars
setting. (Of course, this itself is a security risk and the initial
purpose of limiting the environment).
seeing environment variables you expected, try setting this to ''.