Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI #851

Merged
merged 11 commits into from
Feb 9, 2023
Merged

Fix broken CI #851

merged 11 commits into from
Feb 9, 2023

Conversation

pnasrat
Copy link
Contributor

@pnasrat pnasrat commented Feb 7, 2023

Fix broken CI

This includes the debug PR from @manics #839 and fixes the supplemetal group issue and broken rtd build.

There appears to be some flakiness with integration tests still but have a green build triggered by an empty commit..

Fixes #830

@pnasrat
Copy link
Contributor Author

pnasrat commented Feb 7, 2023

Looks like adding setgroups fixes the ubuntu failures.

Just have an rtd error now

Theme error:
An error happened in rendering the page contributing/code-review.
Reason: UndefinedError("'logo' is undefined")

@pnasrat
Copy link
Contributor Author

pnasrat commented Feb 7, 2023

ok I'm a little confused about the merge conflict coming up here will investigate

@pnasrat
Copy link
Contributor Author

pnasrat commented Feb 7, 2023

Note support for 18.04 should be dropped. That might be a bigger change than for getting this working so will file a separate issue

This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see actions/runner-images#6002

@manics
Copy link
Member

manics commented Feb 9, 2023

Thanks for working on this! It's been a while since I worked on this, but I think most of the additional debugging info is useful for failures so can be kept.

I think we should remove the commented out code though.

@manics manics mentioned this pull request Feb 9, 2023
@pnasrat
Copy link
Contributor Author

pnasrat commented Feb 9, 2023 via email

@pnasrat
Copy link
Contributor Author

pnasrat commented Feb 9, 2023

Ok the 22.04 Py3.10 --upgrade fails with

Traceback (most recent call last):
[34](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:35)
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
[35](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:36)
    return _run_code(code, main_globals, None,
[36](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:37)
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
[37](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:38)
    exec(code, run_globals)
[38](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:39)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/installer.py", line 478, in <module>
[39](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:40)
    main()
[40](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:41)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/installer.py", line 452, in main
[41](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:42)
    ensure_user_environment(args.user_requirements_txt_url)
[42](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:43)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/installer.py", line 197, in ensure_user_environment
[43](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:44)
    with conda.download_miniconda_installer(
[44](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:45)
  File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__
[45](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:46)
    return next(self.gen)
[46](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:47)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/conda.py", line 64, in download_miniconda_installer
[47](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:48)
    raise Exception("sha256sum hash mismatch! Downloaded file corrupted")
[48](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:49)
Exception: sha256sum hash mismatch! Downloaded file corrupted

@pnasrat pnasrat changed the title WIP Attempt to fix ci Fix broken CI Feb 9, 2023
@pnasrat
Copy link
Contributor Author

pnasrat commented Feb 9, 2023

@consideRatio would you have capacity to review and merge this, or a suggestion of another reviewer

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since this is a CI only PR and a clear improvement, I'll go for a merge without awaiting your re-review @manics!

Thank you @pnasrat!!!

@consideRatio consideRatio merged commit c97bdd5 into jupyterhub:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: our test suite is currently broken and needs to be fixed
3 participants