Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance tour version #81

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Enhance tour version #81

merged 3 commits into from
Nov 8, 2023

Conversation

fcollonval
Copy link
Member

What changes:

  • Version is now per tour basis
  • Tour state is stored using the jupyter-server config REST API to be independent of the lab workspaces.
  • Change a couple of argument API to be object based rather than list based.

@fcollonval fcollonval added the enhancement New feature or request label Nov 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Binder 👈 Launch a Binder on branch jupyterlab-contrib/jupyterlab-tour/enh/version

@fcollonval fcollonval merged commit fd7eecc into main Nov 8, 2023
10 checks passed
@fcollonval fcollonval deleted the enh/version branch November 8, 2023 14:01
@jtpio
Copy link
Member

jtpio commented Nov 29, 2023

Tour state is stored using the jupyter-server config REST API to be independent of the lab workspaces.

@fcollonval looks like this could have broken support for JupyterLite?

Is this server state necessary?

Noticed in jupyterlite/jupyterlite#1258 (comment)

This was referenced Nov 29, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcollonval @jtpio