Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add jupyterlab-tour #1258

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Re-add jupyterlab-tour #1258

merged 3 commits into from
Feb 29, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 29, 2023

References

Fixes #1139

Version 4.0.0 of this extension is now available and it seems to have support for both JupyterLab 4 and Notebook 7 according to the changelog: https://github.com/jupyterlab-contrib/jupyterlab-tour/releases/tag/v4.0.0

image

Code changes

Re-enable jupyterlab-tour on the RTD demo website.

User-facing changes

The tours should be available again on https://jupyterlite.rtfd.io/en/stable/try/lab.

Backwards-incompatible changes

None

@jtpio jtpio added the documentation Improvements or additions to documentation label Nov 29, 2023
@jtpio jtpio added this to the 0.2.x milestone Nov 29, 2023
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio
Copy link
Member Author

jtpio commented Nov 29, 2023

Arf this new version of jupyterlab-tour does not seem compatible with JupyterLite 😢

image

Looks like there is now a server extension required?

@jtpio
Copy link
Member Author

jtpio commented Nov 29, 2023

This will likely have to be fixed upstream: jupyterlab-contrib/jupyterlab-tour#82

@jtpio jtpio added the upstream label Nov 29, 2023
@jtpio jtpio modified the milestones: 0.2.x, 0.3.x Feb 28, 2024
@jtpio jtpio mentioned this pull request Feb 28, 2024
@jtpio jtpio marked this pull request as ready for review February 28, 2024 17:39
@jtpio
Copy link
Member Author

jtpio commented Feb 28, 2024

The extension should work in both JupyterLab and Notebook:

image

image

The error in the dev tools console will likely be fixed by jupyterlab-contrib/jupyterlab-tour#85.

@jtpio jtpio modified the milestones: 0.3.x, 0.3.0 Feb 28, 2024
@jtpio jtpio merged commit 96f7eab into jupyterlite:main Feb 29, 2024
20 checks passed
@jtpio jtpio deleted the jupyterlab-tour-rtd branch February 29, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore jupyterlab-tour to demo site
1 participant