Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ui-profiler, improve dispatch, separate jlpm/yarn #143

Merged
merged 22 commits into from
May 28, 2023

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 1, 2023

Overview

  • integrates ui-profiler's Execution Time Benchmark with the existing JupyterLab Benchmark Tests workflow
  • all other ui-profiler benchmarks are executed in a new JupyterLab UI Profiler dispatch workflow - example run (:green_circle:)
    • for now those just attach the JSON blob to playwright reports (see below)
    • in a future PR I would like to either:
      • expose the JSON attachments with results as GitHub artifacts for easier download, or
      • upload the JSON results and JupyterLite with ui-profiler installed somewhere (this way we could ensure version match).

Implementation

  • calls ui-profiler in playwright via exposed app instance (arguments are just options in JSON format)
  • ui-profiler itself is in headless mode (to avoid interfering with the profiling)

Developer-facing changes

New workflows New dispatch workflow
Screenshot from 2023-05-01 20-51-00 Screenshot from 2023-05-01 20-50-47

The new workflow generates an artifact called profiler-report.zip (example):

Screenshot from 2023-05-01 21-54-44

Which includes playwright reports for both reference and challenger runs:

Screenshot from 2023-05-01 21-57-26

Each containing an index.html file with a report including the attachment(s):

Screenshot from 2023-05-01 21-54-22
Screenshot from 2023-05-01 21-54-11

And each of these reports include attachment with JSON blobs that can be interpreted by copying them into JupyterLab instance with jupyterlab-ui-profiler installed into a file with .profile.json extension in ui-profiler-results top-level directory.

@krassowski
Copy link
Member Author

I believe that the plotly failures are unrelated - I tried increasing the delay a bit and it may helped a bit but I still see:

[testing] › ../jupyterlab/notebook.spec.ts:120:9 › JupyterLab Benchmark › measure largePlotly - 1 
[testing] › ../jupyterlab/notebook.spec.ts:120:9 › JupyterLab Benchmark › measure manyPlotly - 1

@krassowski krassowski marked this pull request as ready for review May 1, 2023 21:07
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome.

I'm fine if this got merge even if we still have error on CI.

@krassowski
Copy link
Member Author

Merging to iterate on it in subsequent PRs.

@krassowski krassowski merged commit 66ed34a into jupyterlab:master May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having other large notebooks open while tab switching Proposal: create a user-facing benchmarking extension
2 participants