-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ui-profiler, improve dispatch, separate jlpm/yarn #143
Merged
krassowski
merged 22 commits into
jupyterlab:master
from
krassowski:feat/integrate-profiler
May 28, 2023
Merged
Integrate ui-profiler, improve dispatch, separate jlpm/yarn #143
krassowski
merged 22 commits into
jupyterlab:master
from
krassowski:feat/integrate-profiler
May 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start tracking yarn lock file as otherwise cache on CI goes awry
Try to split yarn/jlpm Yarn for testing, fix tee
Add completer and scroll
Simplify type imports, use `tab-after` position
I believe that the plotly failures are unrelated - I tried increasing the delay a bit and it may helped a bit but I still see:
|
fcollonval
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome.
I'm fine if this got merge even if we still have error on CI.
Merging to iterate on it in subsequent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master
branch #142Overview
JupyterLab Benchmark Tests
workflowJupyterLab UI Profiler
dispatch workflow - example run (:green_circle:)Implementation
Developer-facing changes
The new workflow generates an artifact called
profiler-report.zip
(example):Which includes playwright reports for both reference and challenger runs:
Each containing an
index.html
file with a report including the attachment(s):And each of these reports include attachment with JSON blobs that can be interpreted by copying them into JupyterLab instance with jupyterlab-ui-profiler installed into a file with
.profile.json
extension inui-profiler-results
top-level directory.