Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

add theme API & configuration #33

Merged
merged 1 commit into from
Apr 26, 2021
Merged

add theme API & configuration #33

merged 1 commit into from
Apr 26, 2021

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Apr 26, 2021

  • allows setting theme from CLI with --theme option. Examples: --theme dark (same as --theme "JupyterLab Dark"), --theme light (same as --theme "JupyterLab Light")
  • adds theme namespace to API with functions to interact with theme

fixes #30

@mbektas mbektas requested review from blink1073 and jtpio April 26, 2021 06:12
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit dbdc912 into jupyterlab:main Apr 26, 2021
@martinRenou
Copy link
Member

Amazing! Thanks @mbektas

@jtpio
Copy link
Member

jtpio commented Apr 26, 2021

@mbektas did you want to release a new version with this change?

Otherwise I'm happy to do it. For that particular release we can probably just bump to 3.0.7-2 and publish.

It would also be a good opportunity to address #34

@mbektas
Copy link
Member Author

mbektas commented Apr 27, 2021

@mbektas did you want to release a new version with this change?

Otherwise I'm happy to do it. For that particular release we can probably just bump to 3.0.7-2 and publish.

It would also be a good opportunity to address #34

@jtpio, I will publish now, next time feel free to publish if I forget / am late to do it. 3.0.7-2 is the proper version as you suggested.

@jtpio
Copy link
Member

jtpio commented Apr 27, 2021

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add theme option
3 participants