Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a separate package for the chat panel #205

Closed
brichet opened this issue Jun 1, 2023 · 7 comments
Closed

Have a separate package for the chat panel #205

brichet opened this issue Jun 1, 2023 · 7 comments
Labels
enhancement New feature or request @jupyter-ai/chatui
Milestone

Comments

@brichet
Copy link

brichet commented Jun 1, 2023

Would it be possible to separate the UI stuff of the chat panel into a dedicated package ?

Problem

I started working on the frontend part of a chat panel for jupyter_collaboration at jupyterlab/jupyter-collaboration#155, without knowing about the jupyter-ai chat panel.
The chat panel in this project seems much more complete and I was wondering if we could reuse it for jupyter_collaboration.
It would therefore be nice to depend solely on the UI part, if possible.

Proposed Solution

Separate the UI part of the chat panel in a dedicated package.

@brichet brichet added the enhancement New feature or request label Jun 1, 2023
@welcome
Copy link

welcome bot commented Jun 1, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@JasonWeill JasonWeill changed the title Have a separated package for the chat panel Have a separate package for the chat panel Jun 1, 2023
@JasonWeill JasonWeill added this to the Future milestone Jul 28, 2023
@MarcSkovMadsen
Copy link

To put things into perspective it would also be nice if the different commands like /learn and /ask was also available outside of the jupyter UI.

One use case would be to /learn automatically in pipelines on behalf of 30 users on a JupyterHub. I would be building and providing vector stores automatically for them to use.

I would also love to be able to reuse the vector store they have /learned via the UI in other applications.

I think the /learn and /ask part you have made is really, really nice and efficient and would be so nice to be able to use standalone via python code or a CLI.

@JasonWeill
Copy link
Collaborator

Thank you @MarcSkovMadsen ! I opened #434 to continue the conversation about making learn and ask functionality available outside the chat UI. I appreciate your contribution.

@brichet
Copy link
Author

brichet commented Feb 14, 2024

We've been planning on creating a jupyterlab-chat package.

This package would reside in jupyterlab-contrib, and would be used in jupyter-collaboration.
We'd like to make it generic enough to be used in every extension requiring a chat (like in jupyter-ai).

The chat you developed in jupyter-ai already fits a lot with our requirements (and already works in collaboration).
I wonder if we could reuse your developments in that chat, thinking about the UI part and maybe partially the handler.
In that case, we could add a note in the README/doc giving jupyter-ai authorship of the first implementation.

Of course, we could then contribute to jupyter-ai to use that jupyterlab-chat, if desired.

@dlqqq
Copy link
Member

dlqqq commented Feb 15, 2024

@brichet Yes, please feel free to take inspiration from our existing implementation of a chat panel! By the way, if you're interested, I am open to meeting with other developers working on jupyterlab-chat to offer my thoughts on the design & implementation. I authored most of the chat panel implementation, so I'd be happy to help others who want to do the same (but better).

@brichet
Copy link
Author

brichet commented Feb 16, 2024

Thanks @dlqqq, I'm glad to read that.

By the way, if you're interested, I am open to meeting with other developers working on jupyterlab-chat to offer my thoughts on the design & implementation.

Sure, thanks again, I'll let you know when we get a better overview of this chat on our end.

@JasonWeill
Copy link
Collaborator

Closing because Jupyter Chat now exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request @jupyter-ai/chatui
Projects
None yet
Development

No branches or pull requests

4 participants