CSS rules change default Phosphor overflow

[sccolbert]

This rule changes Phosphor's default overflow visibility for the tab bars:

Which results in this undesired overflow artifact:

Restoring the default overflow rule fixes the problem:

I have no insight as to why the default was changed.

CC @jasongrout @ellisonbg

[ellisonbg]

Would this possibly be a remnant in how we were previously adding drop shadows to the tabs? I don't remember why/where we added this (and apologize if I am the one who added it!).

…

On Fri, Feb 23, 2018 at 10:50 AM, S. Chris Colbert ***@***.*** > wrote: This rule changes Phosphor's default overflow visibility for the tab bars: [image: capture] <https://user-images.githubusercontent.com/137289/36611046-cf788228-1897-11e8-8211-a1bfb7c59f2b.PNG> Which results in this undesired overflow artifact: [image: capture] <https://user-images.githubusercontent.com/137289/36611092-f3870b44-1897-11e8-8c06-51370e70643d.PNG> Restoring the default overflow rule fixes the problem: [image: capture] <https://user-images.githubusercontent.com/137289/36611134-1ae177a6-1898-11e8-9951-33bdfb4b7cf4.PNG> I have no insight as to why the default was changed. CC @jasongrout <https://github.com/jasongrout> @ellisonbg <https://github.com/ellisonbg> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3986>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABr0IVrGyGg66zpvePQxouTp5E6MkD9ks5tXwiHgaJpZM4SRULJ> .

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

[sccolbert]

Looking at it more, it seems like the default was changed in order to "blend" the active tab with the tool bar. This is not the intended way to achieve that effect. The intended way is to make the active tab 1px taller, and translate it down 1px so that it overlaps the lower border. That's how it's done here: http://phosphorjs.github.io/examples/datagrid/

[ellisonbg]

Hmm, I thought we were doing it that way...

[saulshanabrook]

I just confirmed this style causes a bug. I could reproduce it by creating a bunch of tabs and then dragging over the middle bar so they show up overflowing:

If we remove this rule, they do not overflow:

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.