Remove bottom border for tabBar. #6526
Conversation
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Screenshot showing the bottom border is fixed, and #6492 is still fixed:
However, notice that there aren't borders on the sides of the tabs anymore in the dark theme, like there are on the light theme, so you can see where one tab ends and another begins:
|
Not sure if this is from this PR or an existing issue. |
|
Looks like the side border is there, just that the border is Edit: whoa, nice color swatches in the markdown rendering! |
Never mind, seems like there was a caching issue? In reality, it looks like the tabs have background jupyterlab/packages/theme-dark-extension/style/variables.css Lines 92 to 95 in d69ce49 jupyterlab/packages/theme-dark-extension/style/variables.css Lines 202 to 206 in d69ce49 (and where is |
|
@ellisonbg - this pr looks fine. Do you or @ian-r-rose want to take a look at the color issue I pointed above, or should we merge this and open a new issue? |
|
@jasongrout I'm a little reticent to change the theme border colors -- that is likely to have some subtle and wide-ranging implications. I brought something similar up in #6153 and we decided to back off of the change. Or do you mean something different? |
|
This now passing, so I'll merge this and open a follow-up. |
Well, clearly something is wrong in the dark theme since And something seems off for tabs to be using the layout color 2, but border color 1. I'll post my suggestion on a new issue. |
|
I opened #6527 |
…e active tab Fixes jupyterlab#6532 Reverts jupyterlab#6526 Reverts jupyterlab#6492 jupyterlab#3986 is now an issue again, but setting the tab min width to 0px (instead of 36px) and setting the tab overflow to hidden makes it less likely to appear in practice (i.e., the tabs need to be much denser now to overflow into the splitter). Setting the tab overflow to hidden also makes the close icon for tabs not overlap the next tab, which was very confusing. I think this is the best compromise at this point. I also experimented unsuccessfully with setting the z-index of the splitter handle in an attempt to get it to be on top of overflowing tabs.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
References
Fixes #6521