CSS: Remove 'overflow: visible' property from '.p-DockPanel-tabBar' class. #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass to avoid overflow tabs on one panel strip being visible beyond the boundary of another panel strip.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
You are on 🔥 🔥 today @cquah! |
|
@blink1073 Just chipping in to the countdown to 1.0! 😄 |
|
🎉 |
jasongrout
added a commit
to jasongrout/jupyterlab
that referenced
this pull request
Jun 12, 2019
…e active tab Fixes jupyterlab#6532 Reverts jupyterlab#6526 Reverts jupyterlab#6492 jupyterlab#3986 is now an issue again, but setting the tab min width to 0px (instead of 36px) and setting the tab overflow to hidden makes it less likely to appear in practice (i.e., the tabs need to be much denser now to overflow into the splitter). Setting the tab overflow to hidden also makes the close icon for tabs not overlap the next tab, which was very confusing. I think this is the best compromise at this point. I also experimented unsuccessfully with setting the z-index of the splitter handle in an attempt to get it to be on top of overflowing tabs.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #3986.
Code changes
Per the discussion in #3986, this removes the
overflow: visibleproperty from the.p-DockPanel-tabBarclass. This is to fix overflow tabs on one panel strip being visible beyond the boundary of another panel strip. I'm not sure if it has any other side effects but it looks alright on my end so far.User-facing changes
Before:
After:
Backwards-incompatible changes
None