Handle small tabs overflowing and preserve the border bridging for the active tab #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e active tab Fixes jupyterlab#6532 Reverts jupyterlab#6526 Reverts jupyterlab#6492 jupyterlab#3986 is now an issue again, but setting the tab min width to 0px (instead of 36px) and setting the tab overflow to hidden makes it less likely to appear in practice (i.e., the tabs need to be much denser now to overflow into the splitter). Setting the tab overflow to hidden also makes the close icon for tabs not overlap the next tab, which was very confusing. I think this is the best compromise at this point. I also experimented unsuccessfully with setting the z-index of the splitter handle in an attempt to get it to be on top of overflowing tabs.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
CC @ellisonbg. This isn't perfect, but it is a better compromise, I think. I'd rather just say |
Closed
afshin
approved these changes
Jun 12, 2019
|
Thanks for the positive review, @afshin. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #6532
Reverts #6526
Reverts #6492
Unfixes #3986
Code changes
User-facing changes
#3986 is now an issue again, but setting the tab min width to 0px (instead of 36px) and setting the tab overflow to hidden makes it less likely to appear in practice (i.e., the tabs need to be much denser now to overflow into the splitter). Setting the tab overflow to hidden also makes the close icon for tabs not overlap the next tab, which was very confusing.
I think this is the best compromise at this point.
I also experimented unsuccessfully with setting the z-index of the splitter handle in an attempt to get it to be on top of overflowing tabs.
Before, showing the tab bar getting correctly clipped, but no bottom border and the close icons overlapping the adjacent tab.
After, showing the tab bar not getting correctly clipped, but having a bottom border and the close icons getting clipped, as well as showing the tabs sizing down to be much smaller (so the old tab bar clipping issue is harder to trigger)
Backwards-incompatible changes
None.