Fix indentation problem after multi-line Python function definition #14748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
@meeseeksdev tag bug |
fcollonval
requested changes
Jun 26, 2023
There was a problem hiding this comment.
thanks @FoSuCloud
Could you update the specification a bit differently (see below comment)?
GitHub tip: if you use special keywords like Fixes in front of the issue in the PR description, the issue will be linked with this PR easing documentation and repository management 😉
FoSuCloud
changed the title
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 7, 2023
…e Python function definition
krassowski
pushed a commit
that referenced
this pull request
Jul 8, 2023
…unction definition (#14801) Co-authored-by: FoSuCloud <49218295+FoSuCloud@users.noreply.github.com>
smacke
pushed a commit
to smacke/jupyterlab
that referenced
this pull request
Jul 8, 2023
…upyterlab#14748) * fix: indentation problem after multi-line Python function definition * fix: Remove duplicate yarn dependencies * fix: update @codemirror/lang-python version * fix: update @codemirror/lang-python version --------- Co-authored-by: yelipei <yelipei@qianxin.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #14668
Code changes
Use resolutions to limit the @codemirror/lang-python version
Execute "yarn install" and "jlpm build" to update dependencies
User-facing changes
nothing
Backwards-incompatible changes
nothing