Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jupyterlab_pygments a federated labextension #11

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Make jupyterlab_pygments a federated labextension #11

merged 1 commit into from
Apr 7, 2022

Conversation

martinRenou
Copy link
Member

@welcome
Copy link

welcome bot commented Apr 4, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@martinRenou martinRenou marked this pull request as draft April 4, 2022 09:50
@martinRenou martinRenou marked this pull request as ready for review April 4, 2022 10:05
@martinRenou martinRenou mentioned this pull request Apr 4, 2022
Closed
@jtpio
Copy link
Member

jtpio commented Apr 5, 2022

Thanks!

Looks like CI is not triggered on this repo? Or maybe because it's coming from a fork and the workflows are new.

1 similar comment
@jtpio
Copy link
Member

jtpio commented Apr 5, 2022

Thanks!

Looks like CI is not triggered on this repo? Or maybe because it's coming from a fork and the workflows are new.

@SylvainCorlay SylvainCorlay merged commit 6ce0a5f into jupyterlab:master Apr 7, 2022
@welcome
Copy link

welcome bot commented Apr 7, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@martinRenou martinRenou deleted the jupyterlab_extension branch April 7, 2022 14:13
@jtpio
Copy link
Member

jtpio commented Apr 7, 2022

Looks like you would have to rename the branch to main so CI can run.

@martinRenou
Copy link
Member Author

Thanks that must be it indeed, I will rename it

@martinRenou
Copy link
Member Author

Actually I don't have the rights to rename the main branch, I will update the action for now

@jtpio
Copy link
Member

jtpio commented Apr 7, 2022

Just renamed to main...

@martinRenou
Copy link
Member Author

Thanks

@jtpio
Copy link
Member

jtpio commented Apr 7, 2022

Looks like CI is failing: https://github.com/jupyterlab/jupyterlab_pygments/runs/5870961151?check_suite_focus=true

@martinRenou
Copy link
Member Author

Yes I'm looking into it and opening a new PR

@dylex dylex mentioned this pull request Oct 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @jtpio @SylvainCorlay