Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enhance transaction views #1562

Merged
merged 13 commits into from
Oct 18, 2024
Merged

chore: Enhance transaction views #1562

merged 13 commits into from
Oct 18, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Oct 7, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Introduced None view in Views , so that no view will be choosen on UI in case of custom status filters applied by user

Filters and Views are made to be in sync now, if you select a status filter for which view exists , then that view will be shown as selected in UI

This change work similar for Orders, Refunds and Disputes

image
image
image
image

Motivation and Context

How did you test it?

refer description

  1. go to payments
  2. apply any view from top
  3. change status filters
  4. if multiple status filters choosen, no view is shown as selected
  5. in case of single status filter choosen, and if that view exists in top, we will show that view as choosen

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Oct 7, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner October 7, 2024 07:53
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@gitanjli525 gitanjli525 linked an issue Oct 7, 2024 that may be closed by this pull request
[BUG] Transaction view and Filter issues #1525
Open
@gitanjli525 gitanjli525 added the S-in-progress Status: Implementation is underway label Oct 10, 2024
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core and removed S-in-progress Status: Implementation is underway labels Oct 16, 2024
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 4bca186 Oct 18, 2024
24 checks passed
@prajwalnl0 prajwalnl0 deleted the enhance-transaction-views branch October 18, 2024 06:25
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Transaction view and Filter issues
4 participants
@gitanjli525 @Riddhiagrawal001 @sagarnaikjuspay @prajwalnl0