-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(process): add process tracker support for instant refunds #5818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 5 of 5 files. Overall, the semantic diff is 6% smaller than the GitHub diff.
|
AkshayaFoiger
added
A-process-tracker
Area: Process tracker
A-refunds
Area: Refund flows
labels
Sep 5, 2024
SanchithHegde
previously approved these changes
Sep 11, 2024
Chethan-rao
previously approved these changes
Sep 11, 2024
jarnura
requested changes
Sep 11, 2024
crates/router/src/core/refunds.rs
Outdated
))?; | ||
} | ||
} | ||
update_refund |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use match and handle error case
AkshayaFoiger
dismissed stale reviews from Chethan-rao and SanchithHegde
via
September 13, 2024 09:37
b9377c4
SanchithHegde
approved these changes
Sep 13, 2024
Chethan-rao
approved these changes
Sep 13, 2024
jarnura
approved these changes
Sep 13, 2024
cookieg13
pushed a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR
Earlier pending refunds was not added to the process tracker. With this PR, the task will be added in the process tracker and process tracker will update respective refund's status.
How did you test it?
Response
Process_tracker
Refunds table with updated status
Checklist
cargo +nightly fmt --all
cargo clippy