Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(email): Add recipient emails in email config #5964

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

ThisIsMani
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • This PR add recipient emails for recon and prod_intent under email config.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

config/config.example.toml
config/deployments/env_specific.toml
config/development.toml
config/docker_compose.toml
loadtest/config/development.toml

Motivation and Context

Closes #5963.

How did you test it?

curl --location 'http://localhost:8080/user/data' \
--header 'Content-Type: application/json' \
--header 'Authorization: ••••••' \
--data '
{
    "ProdIntent": {
        "is_completed": true,
        "legal_business_name": "test",
        "business_label": "test",
        "business_location": "US",
        "display_name": "test",
        "poc_email": "test",
        "business_type": "test",
        "business_identifier": "test",
        "business_website": "test",
        "poc_name": "test",
        "poc_contact": "test",
        "comments": "test"
    }
} 
'

The above API should send prod intent email to configured prod intent email.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ThisIsMani ThisIsMani added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes C-refactor Category: Refactor A-users Area: Users Recon Area: Reconciliation service labels Sep 19, 2024
@ThisIsMani ThisIsMani self-assigned this Sep 19, 2024
@ThisIsMani ThisIsMani requested review from a team as code owners September 19, 2024 12:17
Copy link

semanticdiff-com bot commented Sep 19, 2024

Review changes with SemanticDiff.

Analyzed 8 of 13 files.

Overall, the semantic diff is 32% smaller than the GitHub diff.

Filename Status
loadtest/config/development.toml Unsupported file format
✔️ crates/router/src/utils/user/dashboard_metadata.rs 46.09% smaller
✔️ crates/router/src/services/email/types.rs 59.29% smaller
✔️ crates/router/src/core/recon.rs 4.1% smaller
✔️ crates/router/src/core/user/dashboard_metadata.rs Analyzed
✔️ crates/router/src/consts/user.rs Analyzed
✔️ crates/router/src/configs/secrets_transformers.rs Analyzed
✔️ crates/router/src/configs/settings.rs Analyzed
✔️ crates/external_services/src/email.rs Analyzed
config/config.example.toml Unsupported file format
config/development.toml Unsupported file format
config/docker_compose.toml Unsupported file format
config/deployments/env_specific.toml Unsupported file format

apoorvdixit88
apoorvdixit88 previously approved these changes Sep 19, 2024
apoorvdixit88
apoorvdixit88 previously approved these changes Sep 19, 2024
racnan
racnan previously approved these changes Sep 19, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 5942e05 Sep 19, 2024
13 of 14 checks passed
@Gnanasundari24 Gnanasundari24 deleted the new-ses-fix branch September 19, 2024 14:16
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-bug Category: Bug C-refactor Category: Refactor M-configuration-changes Metadata: This PR involves configuration changes Recon Area: Reconciliation service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(dashboard_metadata): Fix prod intent emails
8 participants