-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(email): Add recipient emails in email config #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
M-configuration-changes
Metadata: This PR involves configuration changes
C-refactor
Category: Refactor
A-users
Area: Users
Recon
Area: Reconciliation service
labels
Sep 19, 2024
Review changes with SemanticDiff. Analyzed 8 of 13 files. Overall, the semantic diff is 32% smaller than the GitHub diff.
|
apoorvdixit88
previously approved these changes
Sep 19, 2024
apoorvdixit88
previously approved these changes
Sep 19, 2024
racnan
previously approved these changes
Sep 19, 2024
ThisIsMani
dismissed stale reviews from racnan and apoorvdixit88
via
September 19, 2024 12:49
e2c9aad
apoorvdixit88
approved these changes
Sep 19, 2024
SanchithHegde
approved these changes
Sep 19, 2024
Chethan-rao
approved these changes
Sep 19, 2024
sai-harsha-vardhan
approved these changes
Sep 19, 2024
jarnura
approved these changes
Sep 19, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-users
Area: Users
C-bug
Category: Bug
C-refactor
Category: Refactor
M-configuration-changes
Metadata: This PR involves configuration changes
Recon
Area: Reconciliation service
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
config/config.example.toml
config/deployments/env_specific.toml
config/development.toml
config/docker_compose.toml
loadtest/config/development.toml
Motivation and Context
Closes #5963.
How did you test it?
The above API should send prod intent email to configured prod intent email.
Checklist
cargo +nightly fmt --all
cargo clippy