Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user_roles): Send only same and below Entity Level Users in List Users API #6147

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

ThisIsMani
Copy link
Contributor

@ThisIsMani ThisIsMani commented Sep 27, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Send only same and below Entity Level Users in List Users API.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #6146.

How did you test it?

curl 'http://localhost:8080/user/user/v2/list' \
  -H 'authorization: Bearer JWT' \

This API when called with merchant level users, it should not send org level users in response. Can be tested via control center.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ThisIsMani ThisIsMani added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-users Area: Users labels Sep 27, 2024
@ThisIsMani ThisIsMani self-assigned this Sep 27, 2024
@ThisIsMani ThisIsMani requested a review from a team as a code owner September 27, 2024 11:56
Copy link

semanticdiff-com bot commented Sep 27, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 25% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/utils/user_role.rs 32.71% smaller
✔️ crates/router/src/core/user_role.rs Analyzed

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Sep 29, 2024
Merged via the queue into main with commit 3e3c326 Sep 29, 2024
15 of 16 checks passed
@Gnanasundari24 Gnanasundari24 deleted the list-in-lineage-bug branch September 29, 2024 13:15
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(user_roles): Send only same and below Entity Level Users in List Users API
5 participants