Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: intoduce GenericError enum variant in enum ConnectorError #6189

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

intoduced GenericError enum variant in enum ConnectorError
Main branch PR: #6143

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Oct 1, 2024
@hrithikesh026 hrithikesh026 requested review from a team as code owners October 1, 2024 10:43
Copy link

semanticdiff-com bot commented Oct 1, 2024

Review changes with SemanticDiff.

Analyzed 9 of 10 files.

Overall, the semantic diff is 40% smaller than the GitHub diff.

Filename Status
✔️ crates/storage_impl/src/redis/pub_sub.rs Analyzed
✔️ crates/router_env/tests/env.rs 0.75% smaller
✔️ crates/router/src/types/api.rs 41.62% smaller
crates/router/src/services/connector_integration_interface.rs Unsupported file format
✔️ crates/router/src/core/health_check.rs Analyzed
✔️ crates/router/src/core/payments.rs Analyzed
✔️ crates/router/src/core/errors/utils.rs 65.61% smaller
✔️ crates/router/src/connector/globalpay.rs 45.46% smaller
✔️ crates/hyperswitch_interfaces/src/errors.rs Analyzed
✔️ crates/drainer/src/health_check.rs Analyzed

@hrithikesh026 hrithikesh026 requested a review from a team as a code owner October 1, 2024 12:36
@likhinbopanna likhinbopanna merged commit 9531f3d into hotfix-2024.08.02.0 Oct 3, 2024
13 of 15 checks passed
@likhinbopanna likhinbopanna deleted the make-error-type-generic-in-connector-integration-v2-hotfix branch October 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants