docs(v2): Added 'X-Merchant-Id' to headers in Profile API docs #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 2 of 2 files. Overall, the semantic diff is 6% smaller than the GitHub diff.
|
hyperswitch-bot
bot
added
the
M-api-contract-changes
|
Mintlify Screenshots (Notice the header field): 
|
SanchithHegde
approved these changes
Oct 14, 2024
Narayanbhat166
approved these changes
Oct 14, 2024
| "name": "X-Merchant-Id", | ||
| "in": "header", | ||
| "description": "Merchant ID of the profile.", | ||
| "required": true, |
There was a problem hiding this comment.
one small improvement can be made here, these headers are necessary only in case of admin api auth. The JWT auth has these handled. Again this is optional. For someone who is using the api reference would try it with admin api key only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add X-Merchant-Id to headers in Profile endpoints for v2
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy