Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Infoset view #66

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Infoset view #66

merged 2 commits into from
Aug 9, 2021

Conversation

jw3
Copy link
Owner

@jw3 jw3 commented Aug 5, 2021

Adds a virtual doc view of the infoset. In addition to adding the obvious function of viewing this infoset, this work is also attempting to demonstrate an alternative way of managing the editor views by splitting the update out from the display.

commands

  • display: displays the view based on the temp file
  • save: writes the current infoset state to a specified file
  • diff: displays a diff of the current infoset state against the previous infoset state

Diffs here are provided by keeping tabs on the previous infoset state and then using the built in vs code diff tool to run it against the current state. Pretty simple, but effective.

image

Can diff at any point with ctrl+p diff command.

There are some interesting implications of diffing things from more than one step back as well, but didnt implement a history of any sort.

src/infosetView.ts Outdated Show resolved Hide resolved
@jw3 jw3 mentioned this pull request Aug 6, 2021
@jw3 jw3 marked this pull request as ready for review August 9, 2021 05:44
commands
- display current
- save current to file
- diff against previous
@shanedell shanedell merged commit 2f75ea7 into master Aug 9, 2021
@jw3 jw3 deleted the infoset_view branch August 10, 2021 00:16
@jw3
Copy link
Owner Author

jw3 commented Aug 10, 2021

This diff-of-previous-state is similar to how the cli debugger works for the diff command.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request infoset dump Infoset diff view
2 participants