Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uber style guide for wraping errors #42

Closed
jwambugu opened this issue Jan 25, 2024 · 0 comments · Fixed by #43
Closed

Use uber style guide for wraping errors #42

jwambugu opened this issue Jan 25, 2024 · 0 comments · Fixed by #43
Assignees
@jwambugu
Labels
enhancement New feature or request

Comments

@jwambugu
Copy link
Owner

Refer to this guide
@jwambugu jwambugu self-assigned this Jan 25, 2024
@jwambugu jwambugu added the enhancement New feature or request label Jan 25, 2024
jwambugu added a commit that referenced this issue Jan 25, 2024
@jwambugu
Use uber style guide and little housekeeping #42
406fd4b
@jwambugu jwambugu linked a pull request Jan 25, 2024 that will close this issue
Use uber style guide and housekeeping #42 #43
Merged
jwambugu added a commit that referenced this issue Jan 29, 2024
@jwambugu
Use uber style guide and housekeeping #42 (#43)
18aa180 
* Refactor callback unmarshaler signatures - accept `io.Reader`

* Replace `assert` with `require`

* Add new `ResponseType` type for known response types

* Use response status to check for failed requests

* Rename `GeneralResponse` to `Response`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwambugu jwambugu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use uber style guide and housekeeping #42 jwambugu/mpesa-golang-sdk
1 participant
@jwambugu