Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building decoder without algorithm factory #264

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Support building decoder without algorithm factory #264

merged 5 commits into from
Apr 2, 2020

Conversation

abatishchev
Copy link
Member

@abatishchev abatishchev commented Apr 2, 2020 •
edited
Loading

Resolves #263.

  • Added ctor to JwtDecoder without validator and algorithm
  • Updated builder
  • Updated tests
  • Bumped version to 6.1.4

@abatishchev abatishchev added this to the 6.0 milestone Apr 2, 2020
@abatishchev abatishchev self-assigned this Apr 2, 2020
richardhauer
richardhauer approved these changes Apr 2, 2020
View reviewed changes
Copy link

@richardhauer richardhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look appropriate but probably needs test coverage

@abatishchev
Copy link
Member Author

abatishchev commented Apr 2, 2020 •
edited
Loading

@richardhauer can you please the package from this build before I'll publish it?

Can you please also contribute back your NoOpAlgorithm, just in case someone else might need it in the future?

@abatishchev abatishchev merged commit 54f7f94 into master Apr 2, 2020
@abatishchev abatishchev deleted the alex/no-alg-1 branch April 2, 2020 17:46
@abatishchev
Copy link
Member Author

@richardhauer please try 6.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardhauer richardhauer richardhauer approved these changes

Assignees

@abatishchev abatishchev

Labels
core
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JwtDecoder throws error if no Algorithm/Factory specified even though it's not needed
2 participants
@abatishchev @richardhauer