Skip to content

Initial website #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Oct 12, 2018
Merged

Initial website #3

merged 39 commits into from
Oct 12, 2018

Conversation

jamesmudd
Copy link
Member

No description provided.

@Stewori
Copy link
Collaborator

Stewori commented Oct 10, 2018

I found two rather eye catching typos on the pront page:

"Here is an example of running Python code inside simple Java application."
should be
"code inside a simple Java application"

Footer: "Fundation" should be "Foundation".

That said, I think this should be merged right away. Any further correction can be made on top.
Great solution for the archived sites! Looks good.
Thanks a lot for this work!
From my point of view, just go ahead and merge...

@jamesmudd
Copy link
Member Author

Thanks those should be fixed! This PR currently includes the old sites but I stripped out some of the very large content (the podcast mp3 files and the Jython book files). I'm not sure if that's good or not but I don't really want the repository to start off at 300MB. Maybe Git LFS would be useful but i haven't really looked at it.

Currently points to existing jython.org this needs re-hosting somewhere else.
public class JythonHelloWorld {
public static void main(String[] args) {
try(PythonInterpreter pyInterp = new PythonInterpreter()) {
pyInterp.exec("print 'Hello Python World!'");
Copy link
Contributor

@adamburkegh adamburkegh Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should use the new print() syntax in our example, ie

print('Hello Python World!')

Even though the old operator syntax still works in 2.7. It's just starting to look declasse.

This is, if it's not obvious, very much not a blocker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree! I'm too used to using the old print. Hopefully this can be merged soon then you could open a PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure no worries

@jimbaker
Copy link
Member

LGTM for the first version

@jimbaker jimbaker merged commit 9ef49ea into jython:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants