Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add travis ci #3

Merged
merged 7 commits into from
Oct 14, 2019
Merged

Add travis ci #3

merged 7 commits into from
Oct 14, 2019

Conversation

zoripong
Copy link
Member

@zoripong zoripong commented Oct 12, 2019 •
edited
Loading

더 나은 삶을 위해 CI를 추가합니다.

@zoripong zoripong marked this pull request as ready for review October 12, 2019 13:55
@zoripong
Copy link
Member Author

zoripong commented Oct 12, 2019 •
edited
Loading

아직 CI 통과하는지 확인 안해봤어요오 확인 후 리뷰 요청드릴게욥

@zoripong zoripong force-pushed the add-travis-ci branch 14 times, most recently from 6ef13d1 to 05a44be Compare October 12, 2019 15:08
@zoripong zoripong requested a review from kimdoori October 12, 2019 15:11
@zoripong zoripong self-assigned this Oct 12, 2019
@zoripong zoripong added the enhancement New feature or request label Oct 12, 2019
kimdoori
kimdoori reviewed Oct 12, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
kimdoori
kimdoori reviewed Oct 12, 2019
View reviewed changes
.travis.yml
language: python
python:
- 3.6
- 3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 두개 적으면 어떻게 되나욤? 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두 버전에서 모두 테스트 해봅니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

글엏군요 혹시 그래야하는 이유가 있나욤?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큰 이유는 없었습니다 👀

kimdoori
kimdoori reviewed Oct 12, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@zoripong zoripong requested a review from kimdoori October 12, 2019 16:12
kimdoori
kimdoori reviewed Oct 12, 2019
View reviewed changes
Copy link
Contributor

@kimdoori kimdoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90% 어푸릅.. 하나만 확인해주세욤

.travis.yml
language: python
python:
- 3.6
- 3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

글엏군요 혹시 그래야하는 이유가 있나욤?

.travis.yml Show resolved Hide resolved
@zoripong zoripong requested a review from kimdoori October 14, 2019 13:33
kimdoori
kimdoori reviewed Oct 14, 2019
View reviewed changes
Copy link
Contributor

@kimdoori kimdoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore conflict ㄴㅏ욤 해결해주시면 어푸릅하겠습니다.

@zoripong
Copy link
Member Author

리베이스 했습니다아 @kimdoori

@zoripong zoripong requested a review from kimdoori October 14, 2019 14:09
kimdoori
kimdoori approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@kimdoori kimdoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용 👏

@zoripong zoripong merged commit 50e46d6 into k-roffle:master Oct 14, 2019
@zoripong zoripong deleted the add-travis-ci branch October 14, 2019 14:14
zoripong pushed a commit that referenced this pull request Oct 12, 2020
Merge pull request #53 from zoripong/feat/#50
fb43f1b 
[#50] 검색 API 구체화 #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimdoori kimdoori kimdoori approved these changes

Assignees

@zoripong zoripong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoripong @kimdoori