merge upstream 0.0.34 #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in the missing license files. Added requested comment on bakward compatability.
Adding tests for Agent options and validation.
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
update owners
Clean up konnectivity-client go.mod
Improve dial response logging
Adjust server log verbosity to improve signal:noise
Agent: log dialID in DIAL_REQ handling.
Add rudimentary data transfer benchmark tests
See discussion at kubernetes-sigs#381 What I did: - match requirements with k/k release-1.24 branch - for k8s.io/api and friends, take latest 1.24 tag (v0.24.8) - delete indirect require section (to generate from scratch) - go mod tidy
Made sure we properly constructed the admin listener. Make sure we honored the bind address for the Konn Server. Added a bind address option for the Konn Agent.
Fixed admin port listen code.
Update go.mod to be more conservative.
Verify if pkt is nil before logging the type.
Fix segfault on empty packet
…k minor versions.
konnectivity-client: lower goleak version in release-0.0 branch.
Replace deprecated `golint` with `revive`. Upgrade linter to latest version. Apply lint fixes found.
Prepare 0.0.34
v0.0.34: Pick up several new metrics and logging improvements.
Rename variable to make linter happy. Fixes commit 5d769c1 (Extend agent to support traffic from cluster to master network.)
We don't need to listen on all interfaces during testing. Fixes commit 3c39121 (handle data package to agent in the same goroutine)
Ignore the linter error: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec) Fix the linter error: receiver-naming: receiver name t should be consistent with previous receiver name f for testStream (revive)
jnummelin
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.