Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add agent with auth file #10119

Merged
merged 5 commits into from
May 27, 2024

Conversation

npitsillos
Copy link
Contributor

Proposed Changes

Adds a test to address changes in #10074

Types of Changes

Test

Verification

Testing

Adds another node to tailscale test that authenticates using a vpn-auth-file.

Linked Issues

#10064

User-Facing Change

Fix bug when using `vpn-auth-file` in the agent

Further Comments

@npitsillos npitsillos requested a review from a team as a code owner May 17, 2024 10:10
@npitsillos npitsillos force-pushed the fix-tailscale-e2e-test branch 2 times, most recently from 87bc0f2 to 666793a Compare May 17, 2024 10:19
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.71%. Comparing base (aadec85) to head (59c6853).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10119      +/-   ##
==========================================
- Coverage   48.01%   41.71%   -6.30%     
==========================================
  Files         173      173              
  Lines       14658    14658              
==========================================
- Hits         7038     6115     -923     
- Misses       6288     7375    +1087     
+ Partials     1332     1168     -164     
Flag Coverage Δ
e2etests 36.30% <ø> (-10.30%) ⬇️
inttests 37.04% <ø> (+0.07%) ⬆️
unittests 11.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil
Copy link
Contributor

Thanks for this contribution! Please also update to 2 the integer here https://github.com/k3s-io/k3s/blob/master/tests/e2e/tailscale/tailscale_test.go#L17

@npitsillos
Copy link
Contributor Author

I can confirm that the file is correctly copied to the guest machine, however the tailscale key is not picked up from the env
image

@manuelbuil
Copy link
Contributor

I can confirm that the file is correctly copied to the guest machine, however the tailscale key is not picked up from the env image

did you run the test passing the tailscale key?

E2E_TAILSCALE_KEY=xxxxxx go test -v ./test/e2e/tailscale

@npitsillos
Copy link
Contributor Author

no I just exported it as an environment variable

tests/e2e/tailscale/Vagrantfile Outdated Show resolved Hide resolved
@manuelbuil
Copy link
Contributor

Are you testing this? Is it working for you?

@npitsillos
Copy link
Contributor Author

I just managed to run the tests I had issues with running vagrant without sudo. The tests fail but I should rebase my branch with the latest changes that have your code for it right?

@manuelbuil
Copy link
Contributor

I just managed to run the tests I had issues with running vagrant without sudo. The tests fail but I should rebase my branch with the latest changes that have your code for it right?

What's the error you get?

@manuelbuil
Copy link
Contributor

Could you please rebase? That will include my fix :)

Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
@npitsillos
Copy link
Contributor Author

Just rebased from master and pushed the changes

@manuelbuil
Copy link
Contributor

I have just tested and works :). Thanks again @npitsillos

@npitsillos
Copy link
Contributor Author

I'm glad I could contribute here! I am looking forward to contributing on things in the future as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants