-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add agent with auth file #10119
Conversation
87bc0f2
to
666793a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10119 +/- ##
==========================================
- Coverage 48.01% 41.71% -6.30%
==========================================
Files 173 173
Lines 14658 14658
==========================================
- Hits 7038 6115 -923
- Misses 6288 7375 +1087
+ Partials 1332 1168 -164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for this contribution! Please also update to 2 the integer here https://github.com/k3s-io/k3s/blob/master/tests/e2e/tailscale/tailscale_test.go#L17 |
no I just exported it as an environment variable |
Are you testing this? Is it working for you? |
I just managed to run the tests I had issues with running |
What's the error you get? |
Could you please rebase? That will include my fix :) |
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
d5f528e
to
59c6853
Compare
Just rebased from |
I have just tested and works :). Thanks again @npitsillos |
I'm glad I could contribute here! I am looking forward to contributing on things in the future as well! |
Proposed Changes
Adds a test to address changes in #10074
Types of Changes
Test
Verification
Testing
Adds another node to
tailscale
test that authenticates using avpn-auth-file
.Linked Issues
#10064
User-Facing Change
Further Comments