Autocomplete #10
Merged
Autocomplete #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We autocomplete the names of natives, loaded modules, and names in those modules. * Autocompletion inside a string autocompletes file names in the current directory.
|
This PR builds on #9 |
sirlensalot
reviewed
Feb 22, 2018
src/Pact/Repl.hs
Outdated
| completeFn :: (MonadIO m, MonadState ReplState m) => CompletionFunc m | ||
| completeFn = completeQuotedWord (Just '\\') "\"" listFiles $ | ||
| completeWord (Just '\\') ("\"\'" ++ filenameWordBreakChars) $ \str -> do | ||
| modules <- gets (^. rEnv . eeRefStore . rsModules) |
sirlensalot
reviewed
Feb 22, 2018
| completeFn = completeQuotedWord (Just '\\') "\"" listFiles $ | ||
| completeWord (Just '\\') ("\"\'" ++ filenameWordBreakChars) $ \str -> do | ||
| modules <- gets (^. rEnv . eeRefStore . rsModules) | ||
| let namesInModules = concat $ modules ^.. traverse . _2 . to HM.keys |
There was a problem hiding this comment.
use toListOf (traverse . _2 . to HM.keys) $ modules.
to is dope though
sirlensalot
reviewed
Feb 22, 2018
| completeFn :: (MonadIO m, MonadState ReplState m) => CompletionFunc m | ||
| completeFn = completeQuotedWord (Just '\\') "\"" listFiles $ | ||
| completeWord (Just '\\') ("\"\'" ++ filenameWordBreakChars) $ \str -> do | ||
| modules <- gets (^. rEnv . eeRefStore . rsModules) |
joelburget
added a commit
to joelburget/pact
that referenced
this pull request
Feb 22, 2018
sirlensalot
pushed a commit
that referenced
this pull request
Feb 22, 2018
Review fixes for pull #10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.