Adjust gas for natives #1071
Merged
Adjust gas for natives #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
reviewed
Nov 2, 2022
jwiegley
reviewed
Nov 2, 2022
src/Pact/Native.hs
Outdated
| strToList g i [TLitString s] = computeGas' g i (GMakeList $ fromIntegral $ T.length s) $ | ||
| return $ toTListV tTyString def $ stringToCharList s | ||
| strToList g i [TLitString s] = do | ||
| let !len = fromIntegral $ T.length s |
There was a problem hiding this comment.
Here the bang does mean something else: Always compute the length, even if ga is never demanded. I don't think this is necessary, and would rather just let laziness call T.length when and if it needs to, since only one of the arguments to ifExecutionFlagSet' will ever be evaluated, so the bang pattern isn't saving time, it's just shifting the cost of the length from "maybe happens" to "always happens here".
emilypi
approved these changes
Nov 2, 2022
sirlensalot
approved these changes
Nov 4, 2022
jwiegley
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.