Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forked errors on chain #1185

Merged
merged 14 commits into from
Apr 26, 2023
Merged

Forked errors on chain #1185

merged 14 commits into from
Apr 26, 2023

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Apr 6, 2023

No description provided.

@jmcardon jmcardon marked this pull request as draft April 6, 2023 15:46
@jmcardon jmcardon changed the title Forked errors on chian Forked errors on chain Apr 10, 2023
jmcardon
jmcardon commented Apr 14, 2023
View reviewed changes
src/Pact/Types/Runtime.hs Outdated Show resolved Hide resolved
emilypi
emilypi approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - feel free to make the bool change or merge

@jmcardon jmcardon marked this pull request as ready for review April 18, 2023 16:23
jwiegley
jwiegley reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@jwiegley jwiegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Also: have we built this into Chainweb and done a replay?

docs/en/pact-functions.md Outdated Show resolved Hide resolved
src/Pact/Repl/Lib.hs Outdated Show resolved Hide resolved
src/Pact/Types/Runtime.hs Show resolved Hide resolved
jwiegley
jwiegley reviewed Apr 19, 2023
View reviewed changes
src/Pact/Repl/Lib.hs Outdated Show resolved Hide resolved
@edmundnoble edmundnoble mentioned this pull request Apr 19, 2023
Merged
@jmcardon
Copy link
Member Author

Replay pending

@jmcardon
Copy link
Member Author

Replay is 👍

jwiegley
jwiegley reviewed Apr 26, 2023
View reviewed changes
src/Pact/Types/Runtime.hs Outdated Show resolved Hide resolved
jwiegley
jwiegley reviewed Apr 26, 2023
View reviewed changes
src/Pact/Types/Runtime.hs Outdated Show resolved Hide resolved
@jmcardon jmcardon merged commit eba6fa1 into master Apr 26, 2023
jwiegley pushed a commit that referenced this pull request Apr 26, 2023
@jmcardon @emilypi @jwiegley
Forked errors on chain (#1185)
8ebf2ad 
* wip fix args error

* more forked errors

* fix tests

* fix tests

* remove top level native docs on chain

* Add tests for env-in-repl doc protections

* forking more errors

* remove bool blindness

* change in-repl function name

* fork native docs

* env simulate on chain

* Address John's comments

---------

Co-authored-by: Emily Pillmore <emily@kadena.io>
@emilypi emilypi deleted the jose/fix-errs branch April 27, 2023 02:54
@emilypi emilypi mentioned this pull request May 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilypi emilypi emilypi approved these changes

@imalsogreg imalsogreg imalsogreg left review comments

@jwiegley jwiegley jwiegley approved these changes

@sirlensalot sirlensalot Awaiting requested review from sirlensalot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmcardon @jwiegley @imalsogreg @emilypi