Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail define-namespace on bad atom structure #737

Merged
merged 6 commits into from
Nov 27, 2019
Merged

Fail define-namespace on bad atom structure #737

merged 6 commits into from
Nov 27, 2019

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Nov 22, 2019

No description provided.

sirlensalot
sirlensalot requested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@sirlensalot sirlensalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the example, also please add a failure test

src/Pact/Native.hs Outdated Show resolved Hide resolved
sirlensalot
sirlensalot approved these changes Nov 26, 2019
View reviewed changes
src/Pact/Native.hs Outdated Show resolved Hide resolved
Update src/Pact/Native.hs
eddca80 
fix lit suggestion
@sirlensalot sirlensalot merged commit 084e129 into master Nov 27, 2019
@sirlensalot sirlensalot deleted the emily/namespace-bugfix branch November 27, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirlensalot sirlensalot sirlensalot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilypi @sirlensalot