Add emit-event native; support blessed modules and add source chain in crosschain #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirlensalot
changed the title
added 7 commits
April 26, 2021 16:50
|
|
||
| instance SizeOf Yield where | ||
| sizeOf (Yield dataYield prov) = | ||
| sizeOf (Yield dataYield prov _) = |
There was a problem hiding this comment.
Why would you leave the size of the chain id out of this calculation?
There was a problem hiding this comment.
No particular reason, except that perhaps gas is supposed to represent some kind of increased utilization, whereas from a data standpoint, Nothing is equivalent to Just ChainId -- is Nothing worth 0? I didn't want to think about that question.
emmanueldenloye
approved these changes
Apr 29, 2021
jmininger
pushed a commit
to jmininger/pact
that referenced
this pull request
May 21, 2021
…n crosschain (kadena-io#862) * Add emit-event native; support blessed module hashes in crosschain * use nonce for stable test * Add source-chain to Yield with backcompat * up version * add test for sourceChain. TODO need negative/backcompat test * added backcompat, and goldens for yields before and after * move yaml out of ghcjs test * Add emit-event gas regression * bump docs Co-authored-by: Stuart Popejoy <slpopejoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emit-eventallows using a cap as an event without invoking it. This will be important for overloadingTRANSFERwith burn/create and gas events.Yield provenance now checks against blessed hashes. This is important for upgrading
coinwithout breaking in-progress transfers. EDIT: also, Yield adds asourcefield to JSON recording source chain.FlagDisablePact40ensures backcompat with error messages and Yield population.NB:emit-eventdoes not have a gas regression, I will address this in later PRs that make the gas golden easier to diff, and the regression fixture more flexible.