Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impurity in CI build process #881

Merged
merged 8 commits into from
Jun 23, 2021
Merged

Fix impurity in CI build process #881

merged 8 commits into from
Jun 23, 2021

Conversation

jmininger
Copy link
Contributor

No description provided.

@jmininger jmininger changed the title Add ghcjs build to zeus-ci attrset Fix impurity in CI build process Jun 21, 2021
Copy link
Contributor

@emmanueldenloye emmanueldenloye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mightybyte
Copy link
Contributor

@sirlensalot @larskuhtz What is up with this stack build failure? Can we merge anyway?

@larskuhtz
Copy link
Contributor

@mightybyte yeah, I'll take care of the Github actions builds in a separate PR.

Copy link
Contributor

@mightybyte mightybyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look, this doesn't actually run the benchmarks. Furthermore, it doesn't even result in the benchmark executable being in the output derivation. Now that I'm thinking about it...pretty sure this is why I used the nix-shell approach in the first place. :/

@jmininger
Copy link
Contributor Author

I've added a benchmark derivation that actually runs the benchmark in a post-build

@sirlensalot sirlensalot merged commit 1021ecc into master Jun 23, 2021
@sirlensalot sirlensalot deleted the jam@ghcjs-zeus branch June 23, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants