-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix impurity in CI build process #881
Conversation
fb105f1
to
9cae865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sirlensalot @larskuhtz What is up with this stack build failure? Can we merge anyway? |
@mightybyte yeah, I'll take care of the Github actions builds in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second look, this doesn't actually run the benchmarks. Furthermore, it doesn't even result in the benchmark executable being in the output derivation. Now that I'm thinking about it...pretty sure this is why I used the nix-shell approach in the first place. :/
d1cc9a5
to
75bca9a
Compare
I've added a benchmark derivation that actually runs the benchmark in a post-build |
No description provided.