Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic refs in TC/analyze #894

Merged
merged 10 commits into from
Aug 23, 2021
Merged

Support dynamic refs in TC/analyze #894

merged 10 commits into from
Aug 23, 2021

Conversation

sirlensalot
Copy link
Contributor

@sirlensalot sirlensalot commented Jul 22, 2021

Approach is to allow repls to instrument concrete modules to be substituted in for ifaces at typecheck/analyze time.

@sirlensalot sirlensalot requested a review from emilypi July 22, 2021 00:35
@sirlensalot sirlensalot marked this pull request as draft July 22, 2021 00:36
src-tool/Pact/Analyze/Check.hs Outdated Show resolved Hide resolved
src-tool/Pact/Analyze/Check.hs Show resolved Hide resolved
src/Pact/Typechecker.hs Outdated Show resolved Hide resolved
Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending comments

@sirlensalot sirlensalot marked this pull request as ready for review August 23, 2021 16:39
@sirlensalot sirlensalot merged commit e9b3abc into master Aug 23, 2021
@sirlensalot sirlensalot deleted the feat/modref-analyze branch August 23, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants