Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for empty import lists when module hashes are present #901

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Add support for empty import lists when module hashes are present #901

merged 3 commits into from
Sep 11, 2021

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Sep 9, 2021

Closes #898

sirlensalot
sirlensalot requested changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@sirlensalot sirlensalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Do you mind adding a "bad test" for an incorrect module hash?

@emilypi
Add support for empty import lists when module hashes are present
2dcafb7 
- adds test for wrong module hash
- updates update docs
- adds .pact-history to gitignore
@emilypi
Copy link
Member Author

emilypi commented Sep 9, 2021

@sirlensalot done.

@sirlensalot
Copy link
Contributor

@emilypi you need to update PactTestsSpec badErrors for the bad test

@sirlensalot sirlensalot merged commit 1c98eaa into master Sep 11, 2021
@sirlensalot sirlensalot deleted the feat/three-arg-use-imports branch September 11, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirlensalot sirlensalot sirlensalot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support three-arg use and empty import list
2 participants
@emilypi @sirlensalot