Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested defpacts #980

Merged
merged 54 commits into from
Apr 12, 2022
Merged

Nested defpacts #980

merged 54 commits into from
Apr 12, 2022

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Mar 29, 2022 •
edited
Loading

Closes #957

jmcardon and others added 30 commits January 25, 2022 17:35
@jmcardon
wip nested
a371e5c
@jmcardon
nested defpact proto: workinggit diff!
a7028e4
@jmcardon
wip new json for pactexec
32a8470
@emilypi
WIP: continue-nested-pact work
e8e3417
@jmcardon
wip free vars
83b89d0
@jmcardon
free vars
821b6cb
@jmcardon
fix compile
0c7e269
@jmcardon
TC and FV back to full inline
58dda98
@jmcardon
fix tc + fv + add flag
70906f9
@jmcardon
rsLoaded containing refs
9880177
@jmcardon
removed name from rsNatives
a3d6032
@jmcardon
benches
e29bab2
@jmcardon
goodbye stack o7
9428a90
@jmcardon
factor out common def eval
e5ca513
@jmcardon
new gas test
5917228
@jmcardon
gas change
d244598
@jmcardon
I hit tab on accident
8d1945e
@jmcardon
retain loaded fully qual in repl
778c850
bump kpkgs to unordered-containers-0.2.15.0
e36d551
@jmcardon
Merge remote-tracking branch 'origin/jam/bump-kpkgs' into jose/interp…
e1d54ce 
…reter-v3
@jmcardon
golden
525bc5b
@jmcardon
Address comments
dd18a12
@jmcardon
info in FQ lookups
e3db301
@jmcardon
nested exec
32ca8be
@jmcardon
ops
30d2eb7
@jmcardon
continue-nested
33f7b35
@jmcardon
pact step set in yield
f497cc8
@jmcardon
rename pact flag + new repl completions
6d38368
@jmcardon
gas changes
b2d321e
@jmcardon
gas changes on integer ops
331be60
emilypi
emilypi reviewed Mar 31, 2022
View reviewed changes
Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far - just needs tests I think

docs/en/pact-functions.md Outdated Show resolved Hide resolved
src/Pact/Eval.hs Outdated Show resolved Hide resolved
src/Pact/Native.hs Outdated Show resolved Hide resolved
sirlensalot
sirlensalot reviewed Apr 9, 2022
View reviewed changes
Copy link
Contributor

@sirlensalot sirlensalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/Pact/Eval.hs Outdated Show resolved Hide resolved
src/Pact/Eval.hs Show resolved Hide resolved
src/Pact/Eval.hs Outdated Show resolved Hide resolved
src/Pact/Native.hs Outdated Show resolved Hide resolved
tests/GasModelSpec.hs Show resolved Hide resolved
tests/pact/yield.repl Outdated Show resolved Hide resolved
@sirlensalot sirlensalot changed the title Feat/nested defpact Nested defpacts Apr 11, 2022
@jmcardon jmcardon changed the base branch from jose/interpreter-v3 to master April 11, 2022 19:38
@jmcardon jmcardon merged commit 1c517a9 into master Apr 12, 2022
@jmcardon jmcardon deleted the feat/nested-defpact branch June 17, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilypi emilypi emilypi left review comments

@sirlensalot sirlensalot sirlensalot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested defpact Execution/Continuation
3 participants
@jmcardon @sirlensalot @emilypi