Fix: Don't pass ELECTRON_RUN_AS_NODE to subprocess
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses kahole#303, preventing commit messages from being written in remote hosts. In VSCode's `server-cli.js`, it checks for the `ELECTRON_RUN_AS_NODE` environment variable, and if it's present it maps the `fs` module to point to the `original-fs` module: ```javascript (process.env.ELECTRON_RUN_AS_NODE || process.versions.electron) && c.define("fs", ["original-fs"], function (r) { return r; }), ``` This module is present in Electron, but not in base NodeJS; base NodeJS is what's used by the VSCode remote server, so having this environment variable present when `code` is called from a subprocess will cause failure. An alternative, but more involved, fix here might be to move to using `ShellExecution` or `ProcessExecution` rather than `child_process`; I expect that they will support calling `code` from a nested process, but they have a fairly different API.
|
i just tested this on windows working in wsl - and this fixes issue #303 for me. 👍 |
|
can we get this merged, @kahole? current version is broken |
|
Will push new version this week |
|
v0.6.62 published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses #303, which prevents commit messages from being written in remote hosts.
In VSCode's
server-cli.js, it checks for theELECTRON_RUN_AS_NODEenvironment variable, and if it's present it maps thefsmodule to point to theoriginal-fsmodule:This module is present in Electron, but not in base NodeJS; base NodeJS is what's used by the VSCode remote server, so having this environment variable present when
codeis called from a subprocess will cause failure.An alternative, but more involved, fix here might be to move to using
ShellExecutionorProcessExecutionrather thanchild_process; I expect that they will support callingcodefrom a nested process, but they have a fairly different API.