Skip to content

Const driven size reductions #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025
Merged

Const driven size reductions #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions picojson/src/direct_buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ pub struct DirectBuffer<'a> {
impl<'a> DirectBuffer<'a> {
/// Create a new DirectBuffer with the given buffer slice
pub fn new(buffer: &'a mut [u8]) -> Self {
// Reserve 10% of buffer for escape processing, minimum 64 bytes
let escape_reserve = (buffer.len() / 10).max(64);
// Reserve ~12.5% of buffer for escape processing (>>3 instead of /10), minimum 64 bytes
// Avoids expensive 32-bit division on 8-bit AVR targets
let escape_reserve = (buffer.len() >> 3).max(64);

Self {
buffer,
Expand Down Expand Up @@ -348,7 +349,7 @@ mod tests {
// Test with larger buffer
let mut large_buffer = [0u8; 1000];
let large_db = DirectBuffer::new(&mut large_buffer);
assert_eq!(large_db.escape_reserve, 100); // 1000/10 = 100
assert_eq!(large_db.escape_reserve, 125); // 1000 >> 3 = 125
}

#[test]
Expand Down