Protect against go-uefi panics #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 53.18% 53.18%
=======================================
Files 16 16
Lines 1115 1115
=======================================
Hits 593 593
Misses 424 424
Partials 98 98 ☔ View full report in Codecov by Sentry. |
|
no, this is not working because they EXIT directly, crap |
|
Maybe try to fix it upstream by returning an error instead of panicing: https://github.com/Foxboron/go-uefi/blob/48be911532c2b39532bd26b01f425530b8e33244/efi/signature/signature_list.go#L306 ? That function can already return errors, I wonder why it should ever panic. |
mudler
approved these changes
May 14, 2024
ouch, but I'd say it is safe to add a recover statement nevertheless as it is a very delicate portion of the stack |
|
just gonna disable it as this its needed NOW, will submit patches after |
mauromorales
approved these changes
May 14, 2024
seem like go-uefo calls os.exit directly if something fails instead of either panicking (which is recoverable) or returning an error(so the caller can act on that) Disable this for now until we get a proper error handling submitted upstream Signed-off-by: Itxaka <itxaka@kairos.io>
renovate bot
referenced
this pull request
in kairos-io/provider-kairos
May 15, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/kairos-io/kairos-sdk](https://togithub.com/kairos-io/kairos-sdk) | `v0.1.5` -> `v0.1.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kairos-io/kairos-sdk (github.com/kairos-io/kairos-sdk)</summary> ### [`v0.1.6`](https://togithub.com/kairos-io/kairos-sdk/releases/tag/v0.1.6) [Compare Source](https://togithub.com/kairos-io/kairos-sdk/compare/v0.1.5...v0.1.6) #### What's Changed - Protect against go-uefi panics by [@​Itxaka](https://togithub.com/Itxaka) in [https://github.com/kairos-io/kairos-sdk/pull/113](https://togithub.com/kairos-io/kairos-sdk/pull/113) **Full Changelog**: kairos-io/kairos-sdk@v0.1.5...v0.1.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mauromorales
added a commit
that referenced
this pull request
May 23, 2024
](https://renovatebot.com){kind=link}
This reverts commit c643cb5.
mauromorales
added a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that when things go wrong with go-uefi listing the certs it panics instead of returning an error.
try to catch that and return normally as this data is optional and we dont want to stop the execution of the state due to this