#280 Websocket server drop connection on attempting to receive text (… #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve text (JSON) message more than 65535 bytes
kakserpom
reviewed
Jul 16, 2017
| @@ -219,9 +224,12 @@ public function onRead() | |||
| } | |||
| if ($this->pool->maxAllowedPacket <= $dataLength) { | |||
| // Too big packet | |||
| Daemon::log(get_class($this) . ': MaxAllowedPacket limit exeed. Packet size ' . $dataLength . ' bytes when limit ' . $this->pool->maxAllowedPacket . ' bytes'); | |||
kakserpom
reviewed
Jul 16, 2017
| @@ -29,6 +29,8 @@ class V13 extends Connection | |||
|
|
|||
| protected $framebuf = ''; | |||
|
|
|||
| protected $firstFrameOpcodeName; | |||
There was a problem hiding this comment.
This property store first frame opcode name when message is fragmented. So it is $firstFrameOpcodeName. Why not ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…JSON) message more than 65535 bytes
In attempt to accept the message splitted into fragments the server does not respond to the requests. The reason - incorrect watermark range on the "EventBufferEvent" input buffer.
Also we have found out that the current WS protocol implementation doesn't correspond to RFC, namely section 4.4 Fragmentation (https://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-4.4)
According to RFC:
The current implementation does not save first frame opcode value into variable.
This PR solves both problems described above.