Fix nnet3 endpointing to correctly use frame subsampling factor (#1184) #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Nov 15, 2016
| @@ -102,6 +102,7 @@ class DecodableNnet3SimpleOnline: public DecodableInterface { | |||
| /// Indices are one-based! This is for compatibility with OpenFst. | |||
| virtual int32 NumIndices() const { return trans_model_.NumTransitionIds(); } | |||
|
|
|||
| virtual int32 FrameSubsamplingFactor() const { return opts_.frame_subsampling_factor; } | |||
There was a problem hiding this comment.
you can remove the 'virtual' here, since it isn't part of the interface.
Overall this is a little bit of a hack, but if I think of a more general way to do this we can do it later on.
|
Changed FrameSubsamplingFactor() to non-virtual. I agree this PR is a bit of hack. |
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should take care of issue #1184.