WIP: fix for utt2dur when applied on speed-pertubed data #678
Conversation
| @@ -68,7 +70,10 @@ else | |||
| echo "$0: wav-to-duration is not on your path" | |||
| exit 1; | |||
| fi | |||
There was a problem hiding this comment.
I think at this point, if read_entire_file is false, you should check whether the wav.scp has any of the offending sox commands that tend to create this problem, and if so, set it to true and print a message saying why.
There was a problem hiding this comment.
Added code to check if there are any sox commands with keyword "speed"; if so, set read_entire_file=true.
Yiming
| if ! wav-to-duration scp:$data/wav.scp ark,t:$data/utt2dur 2>&1 | grep -v 'nonzero return status'; then | ||
|
|
||
| read_entire_file=false | ||
| if [ `cat $data/wav.scp | sed -n '/sox.*speed/p' | wc -l` -gt 0 ]; then |
There was a problem hiding this comment.
I think a grep or grep -E command with output piped to /dev/null would be more elegant-- grep returns true if it matched at least one line.
There was a problem hiding this comment.
On 11/04/16 21:16, Daniel Povey wrote:
In egs/wsj/s5/utils/data/get_utt2dur.sh
#678 (comment):@@ -68,7 +68,14 @@ else
echo "$0: wav-to-duration is not on your path"
exit 1;
fi
- if ! wav-to-duration scp:$data/wav.scp ark,t:$data/utt2dur 2>&1 | grep -v 'nonzero return status'; then
- read_entire_file=false
- if [
cat $data/wav.scp | sed -n '/sox.*speed/p' | wc -l-gt 0 ]; thenI think a grep or grep -E command with output piped to /dev/null would
be more elegant-- grep returns true if it matched at least one line.
instead of stuffing the output to /dev/null you might want to use -q
-q, --quiet, --silent
Quiet; do not write anything to standard output. Exit
immediately with zero status if any match is found, even if an error was
detected. Also see the -s or --no-messages option. (-q
is specified by POSIX.)
Tony
Speechmatics is a trading name of Cantab Research Limited
We are hiring: www.speechmatics.com/careers
https://www.speechmatics.com/careers
Dr A J Robinson, Founder, Cantab Research Ltd
Phone direct: 01223 794096, office: 01223 794497
Company reg no GB 05697423, VAT reg no 925606030
51 Canterbury Street, Cambridge, CB4 3QG, UK
|
Merging. Thanks! |
In order to fix the issue raised in #671
class WaveInfoHolder and class WaveHolder do not have relationship in terms of inheritance. So currently I did two separate instantiations of SequentialTableReader in the "if else " branches in featbin/wav-to-duration.cc, which duplicate some code. Please let me know if there are better solutions.
Yiming