Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamon-redis: kamon.instrumentation.akka.filters.actors.trace.excludes is not picked #1072

Closed
jtjeferreira opened this issue Nov 11, 2021 · 2 comments

Comments

@jtjeferreira
Copy link
Contributor

Hi!

I was trying the kamon-redis module with redisscala and everything is working fine, except a small detail regarding the traces:

image

Those Tell operations they are still present in the trace, although these traces are excluded in this code

# when using multiple clients, the extension will be alphabetical
# e.g. $a, $b, $c.
# so add exclude clauses as needed
kamon.instrumentation.akka.filters.actors.trace {
excludes += "*/user/RedisClient-$a/**"
excludes += "*/user/RedisClient-$a"
excludes += "*/user/RedisBlockingClient-$a/**"
excludes += "*/user/RedisBlockingClient-$a"
}

In the REPL, I can see those configs are not picked:

scala> kamon.Kamon.config().getConfig("kamon.instrumentation.akka.filters.actors.trace")
val res7: com.typesafe.config.Config = Config(SimpleConfigObject({"excludes":[],"includes":["*/user/**","*/system/sharding**"]}))

scala> kamon.Kamon.config().getConfig("kanela.modules.redis")
val res8: com.typesafe.config.Config = Config(SimpleConfigObject({"description":"Provides tracing for Jedis, Lettuce and Rediscala libraries","instrumentations":["kamon.instrumentation.jedis.JedisInstrumentation","kamon.instrumentation.lettuce.LettuceInstrumentation","kamon.instrumentation.rediscala.RediscalaInstrumentation"],"name":"Redis Instrumentation","within":["redis.clients.jedis.Protocol","io.lettuce.core..*","redis..*"]}))

I suspect this is due to some loading order of the reference.conf files, because adding the above configuration to my application.conf file fixes the problem...

@ivantopo
Copy link
Contributor

This seems to happen only when adding the dependencies one-by-one, instead of using the bundle. Fixing it in a bit.

@ivantopo
Copy link
Contributor

This will get fixed with #1122 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants