-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider going back to having one big repo with all instrumentation #626
Comments
I don't like big fat jars in my distributable. Especially if I'm not using 90% of it, and especially if it's a library that's supposed to be unobtrusive like a monitoring library. Think of the users rather than the developers. Maybe work on the documentation over Christmas ;-) |
Hey @code-colonel, just to be clear on something: this is just about placing all the code together in one repository, but we would still be releasing the very same artifacts we have been releasing so far. There will still be a bundle with everything inside and dedicated artifacts for each module for people who only want to bring what is strictly necessary. In that later case, users will not need to be going from repo to repo to figure out what is the latest version of each individual dependency since all dependencies will always be released with the same version number, and that's something I keep getting asked about a lot (having the same version number for everything).
That one hurt 🤕 although still, very true. Thanks for the feedback! |
Finally released here: https://github.com/kamon-io/Kamon/releases/tag/v2.1.0 |
At some point when we started Kamon we had a single repository with all the code in there. It was convenient to have everything on the same place but for reasons that I really can't remember at the moment we started splitting instrumentation and reporters into dedicated repositories. Funny thing is that somehow we went back to that with the kamon-bundle, not by joining repositories but by putting all dependencies back into a single package that people can reference with a single version number.
Some of the pain points coming up often are:
Rough Idea:
Benefits:
The challenges I see here:
Looking forward to comments on this, it might be a good Christmas project 😄 /cc @dpsoft @mladens @adriancole
The text was updated successfully, but these errors were encountered: