Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tapir instrumentation #1000

Merged
merged 8 commits into from
Apr 22, 2021

Conversation

SimunKaracic
Copy link
Contributor

No description provided.

@SimunKaracic SimunKaracic requested a review from ivantopo April 16, 2021 08:40
@jatcwang
Copy link
Contributor

Question: This will conflict with other http library integration right? So if you're using this with e.g. akka-http backend you should turn off the akka-http server instrumentation?

@SimunKaracic
Copy link
Contributor Author

There should be no conflicts, you'll just get different name spans on your endpoints if you're using both together!
It's working only for akka-http backends right now :)

@SimunKaracic SimunKaracic force-pushed the add-tapir-instrumentation branch 3 times, most recently from dbc6898 to 9500b77 Compare April 21, 2021 08:08
@SimunKaracic SimunKaracic force-pushed the add-tapir-instrumentation branch from 9500b77 to 843acfa Compare April 21, 2021 08:21
@ivantopo ivantopo force-pushed the add-tapir-instrumentation branch from f9ec7f3 to 223c27f Compare April 22, 2021 09:32
@ivantopo ivantopo merged commit 88ddedf into kamon-io:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants